Code Reviewer

Code Reviewer

To become a code reviewer, please email crystal@adadevelopersacademy.org with the following information: * a little background on your experience with Ruby/Rails/coding (short synopsis, LinkedIn link, or GitHub) * your GitHub handle

As a Code Reviewer, you will assess the quality of students' code and provide feedback to them. This can be done in person or remotely.

Your role will be to:
 * know your audience is a group of women who are new to coding--students began their cohort with very little to no experience coding; Ada provides them with 7 months of intensive classroom experience in Ruby, Rails, HTML/CSS, and JS followed by a 5 month industry internship; please define terms, do not assume that they know something already, and do not refer to concepts as something that "programmers should already know", as something that "you can't get a job if you don't understand", or as “easy”. Things that are easy to you may be difficult to someone else, and trivializing them trivializes a person who struggles with them.
 * read the provided assignment description
 * complete an industry-standard code review of student’s code using the student’s github repo
 * leave encouraging, as well as constructive, comments/suggestions/feedback to students
 * allow students to improve their code; our goal is growth, not necessarily getting things right the first time.

What to expect
 * Within your availability, code review as much student work as possible each week using the process described below.

Code Review Process

Here's the process for code reviewing:

1. Check the Volunteer Calendar for assignments that need reviewing 2. Open a repo and read the spec on the assignment

3. Open a couple PRs and just glance at code to get an idea of where students are/what solutions look like.

4. Assigne yourself to a PR to indicate that you will be doing a Code Review for that PR.

5. Code Review :D Be sure to structure your review and feedback in the context of the student's understanding/exposure at that point in time. They're learning very quickly, but have been instructed not to retrofit/refactor early projects with concepts learned later (at least for review; they're encouraged to revisit old projects as practice).

6. End Code Review with a sandwich (Things they did well, opportunities for improvement, Call for questions/clarifications)

7. Respond to the latter if needed

WHERE BE THE REPOS?
 * https://github.com/orgs/Ada-Developers-Academy/teams/c3-code-reviewers/repositories

FOR A SAMPLE CODE REVIEW:
 * Jeremy Review: https://github.com/Ada-Developers-Academy/C3Projects--Calculator/pull/18
 * Kari Review: https://github.com/Ada-Developers-Academy/C3Projects--RandomMenuGenerator/pull/17
 * Chef Review: https://github.com/Ada-Developers-Academy/C3Projects--Scrabble/pull/18

SEE THE STUDENT'S PROCESS FOR TURNING IN PROJECTS:
 * https://github.com/Ada-Developers-Academy/daily-curriculum/blob/master/topic_resources/how-to-turn-in-your-projects.md

FOR AN IDEA OF WHAT'S GOING ON IN THE CLASSROOM:
 * https://github.com/Ada-Developers-Academy/daily-curriculum/blob/master/cohort_schedules/C03_classroom.md